Skip to content

Add histogram to metrics container#33043

Merged
Abacn merged 2 commits intoapache:masterfrom
Naireen:add_histogram_to_metrics_container
Mar 5, 2025
Merged

Add histogram to metrics container#33043
Abacn merged 2 commits intoapache:masterfrom
Naireen:add_histogram_to_metrics_container

Conversation

@Naireen
Copy link
Copy Markdown
Contributor

@Naireen Naireen commented Nov 7, 2024 •
edited
Loading

Add histogram to metrics container.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 2 times, most recently from 7ba2869 to 44cf182 Compare November 7, 2024 22:08
@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 5 times, most recently from 7db8de1 to 2f9125a Compare November 11, 2024 17:33
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Nov 11, 2024

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Nov 11, 2024

Run Go PreCommit

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 3 times, most recently from 3518bf8 to e0dcf4c Compare November 12, 2024 04:23
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Nov 12, 2024

Run Java_Pulsar_IO_Direct PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Nov 12, 2024

Run Java_PVR_Prism_Loopback PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Nov 12, 2024

Run Java_IOs_Direct PreCommit

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (b3e7f55) to head (9929cef).
Report is 22 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #33043      +/-   ##
============================================
- Coverage     59.03%   59.00%   -0.03%     
- Complexity     3186     3193       +7     
============================================
  Files          1146     1147       +1     
  Lines        176129   176150      +21     
  Branches       3366     3375       +9     
============================================
- Hits         103975   103945      -30     
- Misses        68800    68843      +43     
- Partials       3354     3362       +8
Flag Coverage Δ
java 70.29% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from e0dcf4c to 377f753 Compare November 12, 2024 05:54
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Nov 12, 2024

Run Java PreCommit

@Naireen Naireen marked this pull request as ready for review November 12, 2024 16:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 12, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 25, 2025

Run GoPrism PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 25, 2025

Run Java PreCommit

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from 69998f6 to a206265 Compare February 25, 2025 17:22
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 25, 2025

Run Java_Amazon-Web-Services2_IO_Direct PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 25, 2025

Run Java_IOs_Direct PreCommit

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from a206265 to 1fd020c Compare February 25, 2025 23:49
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 26, 2025

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 26, 2025

Run Java PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 26, 2025

Run Java_IOs_Direct PreCommit

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 2 times, most recently from 0007d72 to 3db7af0 Compare February 26, 2025 18:56
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 26, 2025

Run Go PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 26, 2025

Run Java PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 26, 2025

Run Java_GCP_IO_Direct PreCommit

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 3 times, most recently from 3d67a2e to 80482e6 Compare February 27, 2025 17:27
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Feb 27, 2025

Run Java PreCommit

@Naireen Naireen marked this pull request as ready for review March 3, 2025 22:36
@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from 80482e6 to 5989886 Compare March 4, 2025 20:04
@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from 5989886 to 26fbc4c Compare March 4, 2025 21:31
@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Mar 4, 2025

Run Prism_Python PreCommit 3.12

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Mar 4, 2025

Run Java_Examples_Dataflow PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Mar 4, 2025

Run Java PreCommit

@Naireen
Copy link
Copy Markdown
Contributor Author

Naireen commented Mar 4, 2025

Run Java_GCP_IO_Direct PreCommit

Abacn
Abacn approved these changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me

We'll need to monitor ValidateRunner PostCommit test suites after merging this. In the past adding metrics type were seen to broke those tests

@Abacn Abacn merged commit 88031b4 into apache:master Mar 5, 2025
113 checks passed
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
@Naireen @VardhanThigle
Add histogram to metrics container (apache#33043)
70df436 
* Add histogram metric to portable runner

* update naming

---------

Co-authored-by: Naireen <naireenhussain@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abacn Abacn Abacn approved these changes

Assignees

No one assigned

Labels

core dataflow direct extensions gcp io java jet kafka model Next Action: Reviewers portability runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Naireen @Abacn @damccorm